Add mlflow span attribute logging for Genie ask_question inputs and outputs#330
Open
edurdevic wants to merge 1 commit intodatabricks:mainfrom
Open
Add mlflow span attribute logging for Genie ask_question inputs and outputs#330edurdevic wants to merge 1 commit intodatabricks:mainfrom
edurdevic wants to merge 1 commit intodatabricks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Genie.ask_questionfor improved observability: logsspace_id,input.question,input.conversation_idas input attributes andoutput.query,output.description,output.conversation_idas output attributes (intentionally excludesoutput.resultto avoid logging potentially large query results).Test plan
test_ask_question_mlflow_trace_logs_inputs_and_outputs— verifies input/output attributes on a new conversation with a query attachmenttest_ask_question_mlflow_trace_with_conversation_id— verifies input/output attributes when continuing an existing conversation with a text attachmenttest_genie.pycontinue to passMade with Cursor